tests: enable core24 plugin tests #5209
Conversation
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Issue raised: #5207 Signed-off-by: Sergio Schvezov <[email protected]>
- Remove the dotnet test for core24 from build and run - Move the dotnet plugin test to the plugin suite Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
|
@bepri I still need to move those other python tests! |
spread.yaml
Outdated
| tests/spread/core24-suites/plugins/: | ||
| summary: core24 plugin tests | ||
| systems: | ||
| - ubuntu-24.04* |
There was a problem hiding this comment.
do these tests build destructively?
One argument "pro" using something lower than 24.04 is that it lets us catch failures in classic snaps
| SNAP/colcon_msg_package: colcon-msg-package | ||
|
|
||
| systems: | ||
| - ubuntu-22.04 |
There was a problem hiding this comment.
these are using 22.04, is that on purpose?
There was a problem hiding this comment.
no, but I will drop it from here and make the suite use 22.04
There was a problem hiding this comment.
fwiw, they could be handled by the global suite systems filter, which I switched to 22.04, but these tests will not work on non amd64 or arm64, so the filter is more specific
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
…read' into work/CRAFT-3138-core24-plugin-spread
These tests were broken because the prime directory wasn't being made in managed builds
There was a problem hiding this comment.
Probably out of scope here, but I'm curious whether:
- We shouldn't be updating this to a newer kernel for the core24 stuff
- We couldn't disable some more of this kernel config to speed up the time it runs. For example there are device drivers here we probably don't need etc. Basically IMO each config item enabled beyond the bare basics probably deserves its own explanation of what we're testing by enabling it.
There was a problem hiding this comment.
Given that the "new" kernel plugin is in #4302 and I've heard that a new plugin may be written that replaces the effort in that PR, I'm not entirely convinced of the value of porting this test to core24 (although we may as well keep it since it's already here).
I think @lengau's comments are valid and we should request both points when a new plugin is ready to land on main.
| @@ -10,6 +10,7 @@ environment: | |||
| PARAM/classic: "--classic" | |||
| PARAM/poetry: "" | |||
| PARAM/uv: "" | |||
| SNAPCRAFT_BUILD_ENVIRONMENT: "" | |||
There was a problem hiding this comment.
Probably make a note of why here.
There was a problem hiding this comment.
Looks good overall, I have 2 observations:
-
I see many of the task.yamls are still running on 22.04. It's not as important as it used to be when the tests ran in destructive mode, but it is a nice organization method and ideally keeps the spread tests at the same duration across bases. Since you have a
systemskey in thespread.yamlfor thecore24-suites/pluginsentry, you can drop all thesystemsintask.yamls unless it's obvious a particular test has special requirements, like it needs to run on 22.04 or on amd64 only. -
Can you update the scheduled spread test workflow to include the manual tests? For example, kernel and matter are manual.
There was a problem hiding this comment.
Given that the "new" kernel plugin is in #4302 and I've heard that a new plugin may be written that replaces the effort in that PR, I'm not entirely convinced of the value of porting this test to core24 (although we may as well keep it since it's already here).
I think @lengau's comments are valid and we should request both points when a new plugin is ready to land on main.
| restore: | | ||
| cd "${SNAP}" | ||
| snapcraft clean | ||
| rm -f ./*.snap |
There was a problem hiding this comment.
| rm -f ./*.snap | |
| rm -f ./*.snap | |
| rm -rf ./squashfs-root |
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)